Skip to content

Closes #91 Aligned the templates' save directory with {pharmaverseadam} requirements #108

Merged
jwang-lilly merged 3 commits intomainfrom
91_add_adam_datasets_to_pharmaverseadam
Feb 4, 2026
Merged

Closes #91 Aligned the templates' save directory with {pharmaverseadam} requirements #108
jwang-lilly merged 3 commits intomainfrom
91_add_adam_datasets_to_pharmaverseadam

Conversation

@Fanny-Gautier
Copy link
Copy Markdown
Contributor

@Fanny-Gautier Fanny-Gautier commented Nov 20, 2025

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral family codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md under the header # admiral<ext> (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the Reference page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@jwang-lilly
Copy link
Copy Markdown
Collaborator

@Fanny-Gautier, I experienced similar check failures and they would disappear if you get a fresh main and merge main to your feature branch.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 9, 2025

Code Coverage

Package Line Rate Health
admiralneuro 100%
Summary 100% (64 / 64)

@manciniedoardo
Copy link
Copy Markdown
Collaborator

@jwang-lilly once checks pass would you mind merging in this one too? @Fanny-Gautier needs it for pharmaverseadam

@jwang-lilly jwang-lilly merged commit 321e39a into main Feb 4, 2026
16 checks passed
@jwang-lilly jwang-lilly deleted the 91_add_adam_datasets_to_pharmaverseadam branch February 4, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

General Issue: Add ADaM datasets to pharmaverseadam

3 participants